Conversation
jzunigax2
commented
Aug 21, 2026
Contributor
- Created a migration to drop the network_bucket_id column from the mail_accounts table.
- Updated MailAccount interface and model to remove references to networkBucketId.
- Removed related methods and tests for setting networkBucketId in AccountRepository and AccountRepository tests.
- Adjusted fixtures to reflect the removal of networkBucketId.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
xabg2
approved these changes
Aug 24, 2026
…uling - Added AccountPurgeService to handle the deletion of expired accounts based on retention policies. - Introduced JobsModule to schedule account purging tasks using @nestjs/schedule. - Updated configuration to enable or disable cron job execution via environment variables. - Created tests for the account purge scheduler to ensure correct behavior during scheduled runs. - Enhanced AccountRepository with methods to claim expired and stalled deletions. - Updated AccountService to manage account deletion and handle related operations effectively.
- Created a migration to drop the network_bucket_id column from the mail_accounts table. - Updated MailAccount interface and model to remove references to networkBucketId. - Removed related methods and tests for setting networkBucketId in AccountRepository and AccountRepository tests. - Adjusted fixtures to reflect the removal of networkBucketId.
jzunigax2
force-pushed
the
fix/remove-left-over-code
branch
from
September 7, 2026 20:31
6002c84 to
3ff53b1
Compare
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.