Repository navigation
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…ess ID - Updated AccountService and BridgeClient to pass address ID when deleting mail buckets. - Modified related tests to ensure correct behavior with the new address ID parameter. - Improved API request path to include address name for better tracking.
jzunigax2
force-pushed
the
fix/bucket-delete-name-guard
branch
from
September 7, 2026 20:31
16e1f4c to
0ad69c0
Compare
|
xabg2
approved these changes
Sep 8, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bridge#229 made
namerequired onDELETE /v2/gateway/users/:uuid/buckets/:id. Without it the call 400s, andreleaseNetworkBucketonly tolerates 404s, so the whole account purge aborts.The address id is the name the bucket was created with.