Repository navigation
[BR-2340]: fix/add url encoding to the getFolder/FileByPath functions - #440
Merged
Merged
Conversation
CandelR
approved these changes
Sep 21, 2026
jzunigax2
force-pushed
the
fix/url-encode-on-get-by-paths
branch
from
September 21, 2026 13:02
9c64096 to
d24adb2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getFolderByPath and getFileByPath interpolated their argument straight into the query string:
this.client.get(
folders/meta?path=${folderPath}, this.headers());Any reserved character in an item name therefore changed the request rather than the value. & starts a new query param and # is dropped as a fragment before the request is even sent, so both truncate the path — /a&b.txt reaches the API as /a. A literal %2F in a name is decoded server-side into a path separator, and + into a space. In every case the API gets a syntactically valid but different path, so the lookup 404s on an item that exists, or resolves to the wrong one.
Both methods now build the query with URLSearchParams, matching getFolderContentByUuid and getFavorites
No client aside from cli calls these methods