[benchmarker] Add universal scalability law fit#1594
Open
BenjaminPelletier wants to merge 1 commit into
Open
Conversation
BenjaminPelletier
marked this pull request as ready for review
July 25, 2026 05:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR works toward #1566 by adding an analysis utility to fit data to the universal scalability law model and allow easy display of that fit on graphs. The updated single_s2_cell.jsonnet benchmarker configuration yielded this result when run:
The shape of the data in that run is a bit confusing, but the USL fits seem good. I also ran the fit against other data and that seemed reasonable as well. For instance: