Skip to content

Platform API | Add reassign task list endpoint#109

Merged
ozb-ioki merged 1 commit into
mainfrom
reassign-task-list
Jul 5, 2022
Merged

Platform API | Add reassign task list endpoint#109
ozb-ioki merged 1 commit into
mainfrom
reassign-task-list

Conversation

@ozb-ioki

Copy link
Copy Markdown
Collaborator

Add a new custom endpoint to reassign a new vehicle to an existing task list.

@ozb-ioki ozb-ioki self-assigned this Jun 30, 2022
@ozb-ioki ozb-ioki changed the title Add reassign task list for platform API Platform API | Add endpoint reassign task list for Jun 30, 2022
@ozb-ioki ozb-ioki changed the title Platform API | Add endpoint reassign task list for Platform API | Add reassign task list endpoint Jun 30, 2022
@ozb-ioki
ozb-ioki requested review from ans-ioki and tom-ioki July 4, 2022 09:11

@tom-ioki tom-ioki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work :)

model_class: Ioki::Model::Platform::TaskList
),
Endpoints.custom_endpoints(
'task_list',

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nit-picking here. I think we use the plural form of the model for custom endpoints. But I have no idea if this is really a rule or common practice 🤷

No hard opinion here :)

@ozb-ioki
ozb-ioki merged commit eb1540e into main Jul 5, 2022
@ozb-ioki
ozb-ioki deleted the reassign-task-list branch July 5, 2022 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants