Passenger API | Add new attributes for deprecated money objects#125
Merged
Conversation
phylor
force-pushed
the
chore/deprecated-object-attributes
branch
from
September 7, 2022 08:09
24831cd to
ab8ddad
Compare
phylor
marked this pull request as ready for review
September 7, 2022 08:10
rmehner
approved these changes
Sep 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes adapt the passenger API to the new attributes, according to the API documentation.
History (what I deduce from the documentation):
cost: integerMoneytype was introduced. A new attribute was added:cost_object: Moneyalongside the oldcost: integer.costwas then deprecated.cost_objectis deprecated andcostis of typeMoneyThe naming of
Moneyobjects is not yet consistent across the different APIs. There are some objects still including a deprecatedcost: integer.