Add Enter/Escape keypress handling to $ionicPopup.prompt() $.alert() and $ionicPopup.confirm() - #4739
Closed
gregallensworth wants to merge 6 commits into
Closed
Add Enter/Escape keypress handling to $ionicPopup.prompt() $.alert() and $ionicPopup.confirm()#4739gregallensworth wants to merge 6 commits into
gregallensworth wants to merge 6 commits into
Conversation
…dling to .prompt
…dling to .prompt
Contributor
|
Thanks for the PR! We really appreciate it! I would love to merge this PR but it seems that some of the tests are failing. Would you be interested in fixing those tests and resubmitting the pr? |
Contributor
|
Hello! As it has been a little while since there was any activity on this PR i am going to be closing it, but please feel free to open more PR's with us in the future! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More detailed description here:
#4737