Fix broken tests (at least) on osx - #8894
Closed
dennybiasiolli wants to merge 3 commits into
Closed
Conversation
dennybiasiolli
force-pushed
the
fix_tests
branch
from
November 1, 2016 18:57
b5a9cf9 to
40eba77
Compare
Contributor
Author
|
Ref #8994 |
the error launching tests was the following: WARN [watcher]: Pattern "/Users/denny/git/ionic/js/utils/list.js" does not match any file.
when passing 270/4 to openAmount() on osx, ctrl.getOpenAmount() it's equal to 65 but ctrl.left.width/4 it's 67.5. That causes error during karma tests
dennybiasiolli
force-pushed
the
fix_tests
branch
from
December 14, 2016 07:43
40eba77 to
3b23684
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
This fix broken tests (at least) on osx
Changes proposed in this pull request:
Ionic Version: 1.x