Skip to content

gateway: add WithContextHint to handler and implement it on BlocksBackend - #550

Merged
Jorropo merged 1 commit into
mainfrom
01-12-gateway_add_WithContextHint_to_handler_and_implement_it_on_BlocksBackend_
Jan 12, 2024
Merged

gateway: add WithContextHint to handler and implement it on BlocksBackend#550
Jorropo merged 1 commit into
mainfrom
01-12-gateway_add_WithContextHint_to_handler_and_implement_it_on_BlocksBackend_

Conversation

@Jorropo

@Jorropo Jorropo commented Jan 12, 2024

Copy link
Copy Markdown
Contributor

This allows the BlocksBackend to inject a session in the context, it remove the problems where we keep reseting the bitswap session each time we call the fetcher.

@Jorropo
Jorropo requested review from hacdias and lidel as code owners January 12, 2024 11:13

Jorropo commented Jan 12, 2024

Copy link
Copy Markdown
Contributor Author

@codecov

codecov Bot commented Jan 12, 2024

Copy link
Copy Markdown

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (8109917) 65.56% compared to head (992c55c) 65.50%.

Impacted file tree graph

@@                                           Coverage Diff                                           @@
##           01-12-blockservice_add_NewSessionContext_and_EmbedSessionInContext_     #550      +/-   ##
=======================================================================================================
- Coverage                                                                65.56%   65.50%   -0.07%     
=======================================================================================================
  Files                                                                      207      207              
  Lines                                                                    25606    25612       +6     
=======================================================================================================
- Hits                                                                     16788    16776      -12     
- Misses                                                                    7345     7359      +14     
- Partials                                                                  1473     1477       +4     
Files Coverage Δ
gateway/gateway.go 85.03% <ø> (ø)
gateway/blocks_backend.go 42.37% <0.00%> (-0.14%) ⬇️
gateway/handler.go 76.18% <25.00%> (-0.37%) ⬇️

... and 13 files with indirect coverage changes

@hacdias
hacdias force-pushed the 01-12-blockservice_add_NewSessionContext_and_EmbedSessionInContext_ branch from 6c590b8 to 39f6a56 Compare January 12, 2024 12:26
@Jorropo
Jorropo requested a review from a team as a code owner January 12, 2024 12:26
…ksBackend`

This allows the `BlocksBackend` to inject a session in the context, it remove the problems where we keep reseting the bitswap session each time we call the `fetcher`.
@Jorropo
Jorropo force-pushed the 01-12-blockservice_add_NewSessionContext_and_EmbedSessionInContext_ branch from 39f6a56 to 8109917 Compare January 12, 2024 12:29
@Jorropo
Jorropo force-pushed the 01-12-gateway_add_WithContextHint_to_handler_and_implement_it_on_BlocksBackend_ branch from 20035c9 to 992c55c Compare January 12, 2024 12:29

Jorropo commented Jan 12, 2024

Copy link
Copy Markdown
Contributor Author

Merge activity

  • Jan 12, 7:42 AM: @Jorropo started a stack merge that includes this pull request via Graphite.
  • Jan 12, 7:43 AM: @Jorropo merged this pull request with Graphite.

@Jorropo
Jorropo changed the base branch from 01-12-blockservice_add_NewSessionContext_and_EmbedSessionInContext_ to main January 12, 2024 12:42
@Jorropo
Jorropo merged commit bcb321c into main Jan 12, 2024
@Jorropo
Jorropo deleted the 01-12-gateway_add_WithContextHint_to_handler_and_implement_it_on_BlocksBackend_ branch January 12, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants