Skip to content

Windows CI fix #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alsora merged 1 commit into from
Feb 10, 2022
Merged

Windows CI fix #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions rclcpp/include/rclcpp/experimental/subscription_intra_process_base.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ class SubscriptionIntraProcessBase : public rclcpp::Waitable
: gc_(context), topic_name_(topic_name), qos_profile_(qos_profile)
{}

RCLCPP_PUBLIC
virtual ~SubscriptionIntraProcessBase();

RCLCPP_PUBLIC
Expand Down
2 changes: 2 additions & 0 deletions rclcpp/include/rclcpp/waitable.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,7 @@ class Waitable
*
* \param[in] callback functor to be called when the waitable becomes ready
*/
RCLCPP_PUBLIC
virtual
void
set_on_ready_callback(std::function<void(size_t, int)> callback);
Expand All @@ -234,6 +235,7 @@ class Waitable
* Note: this function must be overridden with a proper implementation
* by the custom classes who inherit from rclcpp::Waitable if they want to use it.
*/
RCLCPP_PUBLIC
virtual
void
clear_on_ready_callback();
Expand Down