Conversation
New "borderless" setting (default off, live-toggleable) drops the preview chrome — title strip + colored border — and renders the thumbnail edge to edge. The character name stays readable on a translucent backdrop; since there's no border to signal focus, the *active* client's name is drawn in Nicotine red (the color the active border uses in bordered mode). - config: `borderless` field + serde default + LiveSettings mirror so the panel toggle takes effect without a daemon restart; round-trip test. - X11: `thumbnail_rect()` layout helper (full-window vs. inset), red name pixmap baked alongside the cream one, reordered paint (thumbnail first, then backdrop + name) in borderless mode, `apply_live_borderless()`. - Windows: DWM thumbnails composite on top of the host window, so the name can't float over the mirror — borderless drops the frame and keeps a slim translucent name bar (red when active) instead. `apply_live_borderless()`. - config panel: "Borderless previews" checkbox.
Hovering a preview now highlights it the same way the active client is highlighted — red border in bordered mode, red name in borderless mode — by keying the highlight on `is_active || hovered`. - X11: select ENTER_WINDOW | LEAVE_WINDOW, `set_hover()` on NORMAL-mode crossings (grab-synthesized crossings are filtered so drags don't flicker the highlight), repaint on change. - Windows: WM_MOUSEMOVE arms WM_MOUSELEAVE via TrackMouseEvent and flips `hovered`; both repaint. Hover relies on real pointer-crossing/mouse messages, which are NOT delivered under click-through (empty X11 input region / WS_EX_TRANSPARENT), so the highlight is automatically inert when click-through is enabled — as required.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
is_active || hovered. Naturally inert under click-through (no pointer events reach the windows).