Skip to content

fix: stop ignoring committed testdata fixtures#203

Merged
wcollins merged 1 commit into
itential:mainfrom
wcollins:fix/gitignore-testdata-fixtures
Jun 25, 2026
Merged

fix: stop ignoring committed testdata fixtures#203
wcollins merged 1 commit into
itential:mainfrom
wcollins:fix/gitignore-testdata-fixtures

Conversation

@wcollins

Copy link
Copy Markdown
Contributor

Description

The blanket testdata/ ignore (mislabeled "Test cache") was swallowing Go test fixtures, which are committed by convention. This forced contributors to git add -f every fixture and recently caused PR #202's tests to panic when fixtures were silently left out of a commit.

Type of Change

  • Bug fix

Changes Made

  • Remove the blanket testdata/ rule so Go fixtures under testdata/ are tracked normally
  • Make the fuzz ignore depth-agnostic (testdata/fuzz/ -> **/testdata/fuzz/) so generated corpora stay ignored at any depth, preserving prior behavior
  • Keep *_testdata/ untouched (matches nothing tracked)

Testing

  • git check-ignore confirms existing fixtures (e.g. pkg/services/testdata/...) are no longer ignored
  • git check-ignore confirms fuzz corpora at root and nested paths remain ignored
  • No previously force-added fixtures are affected; future fixtures no longer need -f

Checklist

  • Code follows the project's style guidelines
  • Self-review of code has been performed
  • Commits follow conventional format
  • No secrets or credentials committed

@wcollins wcollins added the bug Something isn't working label Jun 25, 2026
@wcollins wcollins merged commit 27a17a0 into itential:main Jun 25, 2026
1 check passed
@wcollins wcollins deleted the fix/gitignore-testdata-fixtures branch June 25, 2026 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant