fix: stop ignoring committed testdata fixtures#203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The blanket
testdata/ignore (mislabeled "Test cache") was swallowing Go test fixtures, which are committed by convention. This forced contributors togit add -fevery fixture and recently caused PR #202's tests to panic when fixtures were silently left out of a commit.Type of Change
Changes Made
testdata/rule so Go fixtures undertestdata/are tracked normallytestdata/fuzz/->**/testdata/fuzz/) so generated corpora stay ignored at any depth, preserving prior behavior*_testdata/untouched (matches nothing tracked)Testing
git check-ignoreconfirms existing fixtures (e.g.pkg/services/testdata/...) are no longer ignoredgit check-ignoreconfirms fuzz corpora at root and nested paths remain ignored-fChecklist