fix: change Tags from []string to []Tag for transformations, analytic-templates and command-templates#205
Open
davhparry wants to merge 1 commit into
Open
Conversation
…-templates and command-templates
Exporting assets with tags caused an unmarshal error because Tags was
typed as []string, but the platform API returns tag objects with _id,
name and description fields. Changed Tags to []Tag on Transformation,
AnalyticTemplate and CommandTemplate structs, and initialised the field
to []Tag{} in each factory function so newly created assets emit
"tags": [] to match the API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Changes Made
Testing
make test passes with no failures- done
Export a transformation, analytic-template, or command-template that has tags assigned — verify tags are preserved in the exported file - done
Import the exported file back — verify import succeeds without unmarshal errors - done
Export an asset with no tags — verify the output contains "tags": [] rather than omitting the field - done
New unit tests added for all three resource types covering: export with tags, export with empty tags, import with tags, and factory initialization
Related Issues
Closes: 201
Checklist
make setupor relevant profiletype: subject)enhancement,bug,documentation,refactor,chore)