fix: preserve trigger options field during automation import/export#206
Open
davhparry wants to merge 1 commit into
Open
fix: preserve trigger options field during automation import/export#206davhparry wants to merge 1 commit into
davhparry wants to merge 1 commit into
Conversation
Adds Options field to all trigger structs so LCM action configuration (actionId, chooseTargetAtRuntime) is no longer dropped during export/import. Also adds a default passthrough in transformTrigger and updateTriggers so unknown trigger types are preserved rather than erroring or being silently dropped. Fixes itential#177
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds Options field to all trigger structs so LCM action configuration (actionId, chooseTargetAtRuntime) is no longer dropped during export/import. Also adds a default passthrough in transformTrigger and updateTriggers so unknown trigger types are preserved rather than erroring or being silently dropped.
Fixes #177
Type of Change
Changes Made
ManualTrigger.MarshalJSONto includeOptionswhen presentdefaultcase intransformTrigger(export path) with a passthrough that preserves unknown trigger types as raw JSONdefaultcase toupdateTriggers(import path) so unknown trigger types are no longer silently droppedTesting
resource_modelscomponentType that has an LCM action trigger — verifyoptions(actionId,chooseTargetAtRuntime) appears in the exported JSONmake test— all tests passChecklist
make setupor relevant profiletype: subject)enhancement,bug,documentation,refactor,chore)