Use Pydantic for Manifest valdiation - #90
Merged
olivhoenen merged 21 commits intoJul 2, 2026
Merged
Conversation
Yannicked
marked this pull request as ready for review
June 18, 2026 13:14
Yannicked
requested review from
SimonPinches,
maarten-ic,
olivhoenen and
prasad-sawantdesai
as code owners
June 18, 2026 13:14
Contributor
|
@Yannicked can you fix the conflicts in this PR? Some of these are coming from the patch from @jholloc w.r.t manifest v1 handling. |
Collaborator
Author
V1 manifests should now be automatically converted to V2 and display a deprecation warning |
olivhoenen
reviewed
Jul 1, 2026
Yannicked
force-pushed
the
feature/pydantic-manifest
branch
from
July 2, 2026 07:36
2e174c1 to
1be6b00
Compare
olivhoenen
approved these changes
Jul 2, 2026
Contributor
@jholloc can you try |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switched
Manifestvalidation logic to Pydantic models and replaced the custom URI class withpydantic.AnyUrl