Retire setup.yml release-tarball builder; tag = source-only Release - #64
Open
krystophny wants to merge 1 commit into
Open
Retire setup.yml release-tarball builder; tag = source-only Release#64krystophny wants to merge 1 commit into
krystophny wants to merge 1 commit into
Conversation
krystophny
commented
Aug 9, 2026
krystophny
left a comment
Member
Author
There was a problem hiding this comment.
Review verdict: Comment
Summary: The workflow removal is consistent with moving setup to source/devcontainer paths, but the README overstates what a v* tag now produces.
Findings:
- [minor] README.md:63 — Deleting
setup.ymlremoves the workflow that created GitHub Release objects; a tag alone provides source archives but does not produce a “source-only Release.” This makes the documented release behavior inaccurate. Clarify that tags expose GitHub-generated source archives, or retain/add a release-creation workflow.
Verdict: Comment — The change is otherwise coherent, but the release documentation should be corrected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PR #54 removes
main.yml, the umbrella build-everything CI.setup.ymlbuiltand published the release tarball (
code-<tag>.tar.gz) thatmain.ymldownloaded for prebuilt dependencies, so once #54 lands
setup.ymlhas noconsumer.
Furthermore the bundle was not reusable: the dependency scripts bake absolute
install prefixes and the venv bakes absolute shebangs tied to the GitHub runner
path, so extracting it anywhere else broke. The devcontainer image builds its
deps from source via
scripts/setup.sh; nothing else references the releasedasset. GitHub already attaches a source archive to every release created from a
tag, so a hand-rolled source tarball is redundant.
Decision
Retire
setup.yml(issue #56, option B). Av*tag remains areproducibility snapshot, published as a source-only Release; fresh setups run
scripts/setup.sh, and the fast path is the devcontainer image(
.devcontainer/). The README "Initial setup" section is updated to say so.The dedicated
release.ymlreplacement (a tinygh release createworkflow)could not be added in this environment because the automation token lacks the
workflowscope GitHub requires to create/update.github/workflows/*files;deleting
setup.ymlwas permitted. The repo therefore keeps tag-triggeredreleases out of the box, and a maintainer with
workflowscope can add theminimal
release.yml(see the triage note on #56) before the next tag.Tests
No build/test suite is affected: nothing under
tests/referenced the releasetarball, and
scripts/setup.shand the devcontainer path build dependenciesfrom source rather than from the asset. Verified
setup.ymlis gone from thetree and the only remaining reference to the release asset is
.github/workflows/main.yml, which pins the existingv2025.01.02release(whose asset stays published permanently) and is itself removed by PR #54.
Closes #56