Adopt the proposed development model (infra relocation) - #65
Open
krystophny wants to merge 1 commit into
Open
Conversation
Relocate this repository to $CODE/infra, treat external/ as a workspace-shared directory at $CODE/external, and retire the umbrella build-everything main.yml CI. Add the development model design note (docs/development-model.md) and workflow templates (docs/templates/downstream-integration.yml, upstream-release.yml). Closes #57
krystophny
commented
Aug 9, 2026
krystophny
left a comment
Member
Author
There was a problem hiding this comment.
Review verdict: Comment
Summary: The workspace relocation is mostly consistent, and shell syntax checks pass. The reset script still targets the old repository-local layout.
Findings:
- [minor] scripts/reset.sh:8-10 — After
libneoandexternalmoved to the workspace parent, these commands still removeinfra/libneoandinfra/external/fgsl-1.6.0, leaving the shared checkout and dependency untouched. Update them to use$CODE/libneoand$CODE/external/fgsl-1.6.0(and unsetINFRAas well).
Verdict: Comment — one non-blocking cleanup regression remains.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves the implemented portion of the tracking issue for adopting the proposed development model (
docs/development-model.md).Problem
Issue #57 tracks adopting the proposed development model. The core relocation work (PR #54) was never merged: this repository still acted as the workspace root with a build-everything umbrella CI (
main.yml) that never passed and aCODElayout that cannot support reproducible per-code builds and release-time downstream validation.Change
$CODE/infra;$CODEis now the workspace root,external/is workspace-shared at$CODE/external.main.yml).docs/development-model.mdand workflow templatesdocs/templates/downstream-integration.ymlanddocs/templates/upstream-release.yml.INFRA/CODEand build shared deps into$CODE/external.Model in one line
a self-describing
find_or_fetchgraph, per-code CI at the source, and release-time reverse-dependency validation owned by the upstream.Tests
No new automated tests; the change is a CI/layout relocation.
git applyof the diff is clean,setup.sh/activate.shconsistently reference$INFRA/$CODE, and the removedmain.ymlis no longer referenced by any workflow.Closes #57