Feature/#610 Configure plugin locations - #611
kaklakariada wants to merge 6 commits into
Conversation
|
61 files. Dude, you are killing me! 🤣 I will do my very best to stay focused on the review. |
There was a problem hiding this comment.
Curiosity: why are there so many formatter changes in a PR about configuring plugin locations?
| * configuration for the service loader | ||
| */ | ||
| ServiceLoaderFactory(final Path pluginsDirectory, final boolean searchCurrentClasspath) | ||
| ServiceLoaderFactory(final ServiceLoaderConfig config) |
There was a problem hiding this comment.
Maintainability: We might want to start marking internal APIs, so that we make sure we can have a clear distinction of what constitutes a breaking change and what does not.
Of the top of my head I would not count this class as part of the public interface. Though I am also 50% sure that someone (maybe even me) used that in their derived project. E.g., the IDE plugin.
There was a problem hiding this comment.
UX: Convention should also be encoded in the project. Not necessarily here. But generally. I don't like configuration. It's a last resort that you need sometimes. Convention however I do like because it make the userguide simpler and improves user experience.
Just to make an example: "$HOME"/.openfasttrace/plugins would be something where we should always look for plugins.
Closes #610