Skip to content

#612 Add tag importer support for Visual Basic files - #616

Open
codenaveed wants to merge 5 commits into
itsallcode:mainfrom
codenaveed:#612_vbsupportclear
Open

codenaveed wants to merge 5 commits into
itsallcode:mainfrom
codenaveed:#612_vbsupportclear

Conversation

@codenaveed

Copy link
Copy Markdown

Closes #612 by adding vb support

@redcatbear redcatbear changed the title #612 vbsupportclear #612 Add tag importer support for Visual Basic files Sep 28, 2026
@redcatbear

Copy link
Copy Markdown
Collaborator

Thank you for your contribution, @codenaveed. Please add an entry to the changelog of 4.11.0 (doc/changes/changes_4.11.0.md).

@codenaveed

Copy link
Copy Markdown
Author

Thank you for your contribution, @codenaveed. Please add an entry to the changelog of 4.11.0 (doc/changes/changes_4.11.0.md).

Thank you for the review. I have added the changelog of 4.11.0 in latest commit [9595ddc]

@ParameterizedTest
@CsvSource(
{ "md", "oreqm", "java", "feature", "zip" })
{ "md", "oreqm", "java", "feature", "vb", "zip" })

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{ "md", "oreqm", "java", "feature", "vb", "zip" })
{ "md", "oreqm", "java", "feature", "zip" })

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding VB here is not necessary. The file extensions trigger all importers already. Java and VB are both handled by the tag importer.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding VB here is not necessary. The file extensions trigger all importers already. Java and VB are both handled by the tag importer.

Thanks for checking. It is corrected in bdcddb0

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🔨 In Progress

Development

Successfully merging this pull request may close these issues.

Add support for Visual Basic files

2 participants