Add formatting and linting - #20
Open
kate-atherton wants to merge 3 commits into
Open
kate-atherton wants to merge 3 commits into
kate-atherton wants to merge 3 commits into
Conversation
kate-atherton
commented
May 22, 2023
Collaborator
- Installs eslint, prettier and husky
- Adds format and lint scripts
- Applies new formatting and linting fixes
- Adds pre-commit and pre-push hooks to ensure code quality
jakec-github
requested changes
May 28, 2023
jakec-github
left a comment
Owner
There was a problem hiding this comment.
Nice stuff. One comment to address
| @@ -0,0 +1,4 @@ | |||
| { | |||
| "singleQuote": true, | |||
| "trailingComma": "none" | |||
Owner
There was a problem hiding this comment.
I would prefer trailingComma was set to "always" or equivalent. It better matches the existing code and works well with auto-formatting tools
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.