Skip to content

test: invoke typescript compiler through npx package#719

Merged
jdx merged 1 commit into
mainfrom
codex/fix-typescript-sdk-typecheck
Jul 13, 2026
Merged

test: invoke typescript compiler through npx package#719
jdx merged 1 commit into
mainfrom
codex/fix-typescript-sdk-typecheck

Conversation

@jdx

@jdx jdx commented Jul 12, 2026

Copy link
Copy Markdown
Owner

Summary

  • invoke tsc from the explicitly selected typescript npm package
  • prevent npx from treating tsc as a source-file argument

Root cause

The SDK compile test ran npx --yes typescript tsc --project .... With the CI runner's npx behavior, the extra tsc token was forwarded to the compiler as a source file, which cannot be combined with --project and caused TS5042 in the test and coverage jobs.

Validation

  • rustup run stable cargo test -p usage-lib --test sdk_compile

Note

Low Risk
Test-only change to the npx argument list; no production or SDK generation behavior is modified.

Overview
Fixes the TypeScript SDK compile test on CI by changing how tsc is launched through npx.

The test now passes --package, typescript before tsc, so npx runs the compiler from the typescript package instead of forwarding a stray tsc token as a source file (which conflicted with --project and triggered TS5042).

Reviewed by Cursor Bugbot for commit 7c6ae85. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai

coderabbitai Bot commented Jul 12, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@jdx, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 40 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 2ea2b07f-1b7a-4e47-ad4a-9ceb1f93d0ed

📥 Commits

Reviewing files that changed from the base of the PR and between 0d01bd2 and 7c6ae85.

📒 Files selected for processing (1)
  • lib/tests/sdk_compile.rs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@greptile-apps

greptile-apps Bot commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Fixes the npx invocation in the TypeScript SDK compile test by adding the --package flag so that typescript is recognized as the package to install rather than as a positional argument, and tsc is correctly treated as the command to run — not as a source-file argument that conflicts with --project.

  • Replaces npx --yes typescript tsc --project with npx --yes --package typescript tsc --project, matching the documented npx usage for named-package execution.
  • Resolves the TS5042 error that was causing the sdk_compile test and coverage jobs to fail in CI.

Confidence Score: 5/5

A minimal, targeted one-line fix to a test helper; no production logic is touched and the change directly resolves the documented CI failure.

The single-character diff adds --package to the npx args array, which is the correct flag to explicitly scope the installed package. The rest of the test is unchanged, and the fix is straightforward with no side-effects.

No files require special attention.

Important Files Changed

Filename Overview
lib/tests/sdk_compile.rs Fixes the npx invocation for tsc by adding --package typescript so npx treats typescript as the package to install and tsc as the command to execute, eliminating the TS5042 error in CI.

Reviews (1): Last reviewed commit: "test: invoke typescript compiler through..." | Re-trigger Greptile

@jdx
jdx merged commit 5e1ad83 into main Jul 13, 2026
6 checks passed
@jdx
jdx deleted the codex/fix-typescript-sdk-typecheck branch July 13, 2026 19:24
mise-en-dev added a commit that referenced this pull request Jul 14, 2026
### 🐛 Bug Fixes

- **(parse)** allow hyphen-prefixed flag values by
[@jdx](https://github.com/jdx) in
[#715](#715)

### 📚 Documentation

- redesign logo as flat vector flag mark by
[@jdx](https://github.com/jdx) in
[#714](#714)

### 🧪 Testing

- invoke typescript compiler through npx package by
[@jdx](https://github.com/jdx) in
[#719](#719)

### 🔍 Other Changes

- **(release)** skip ai reviews for release prs by
[@jdx](https://github.com/jdx) in
[#718](#718)
- schedule releases for Monday morning by [@jdx](https://github.com/jdx)
in [#710](#710)
- gate autorelease on fix and feat commits by
[@jdx](https://github.com/jdx) in
[#716](#716)
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Jul 15, 2026
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [usage](https://github.com/jdx/usage) | patch | `3.5.4` → `3.5.5` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>jdx/usage (usage)</summary>

### [`v3.5.5`](https://github.com/jdx/usage/blob/HEAD/CHANGELOG.md#355---2026-07-13)

[Compare Source](jdx/usage@v3.5.4...v3.5.5)

##### 🐛 Bug Fixes

- **(parse)** allow hyphen-prefixed flag values by [@&#8203;jdx](https://github.com/jdx) in [#&#8203;715](jdx/usage#715)

##### 📚 Documentation

- redesign logo as flat vector flag mark by [@&#8203;jdx](https://github.com/jdx) in [#&#8203;714](jdx/usage#714)

##### 🧪 Testing

- invoke typescript compiler through npx package by [@&#8203;jdx](https://github.com/jdx) in [#&#8203;719](jdx/usage#719)

##### 🔍 Other Changes

- **(release)** skip ai reviews for release prs by [@&#8203;jdx](https://github.com/jdx) in [#&#8203;718](jdx/usage#718)
- schedule releases for Monday morning by [@&#8203;jdx](https://github.com/jdx) in [#&#8203;710](jdx/usage#710)
- gate autorelease on fix and feat commits by [@&#8203;jdx](https://github.com/jdx) in [#&#8203;716](jdx/usage#716)

</details>

---

### Configuration

📅 **Schedule**: (UTC)

- Branch creation
  - At any time (no schedule defined)
- Automerge
  - At any time (no schedule defined)

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4yNTcuMiIsInVwZGF0ZWRJblZlciI6IjQzLjI1Ny4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiLCJhdXRvbWF0aW9uOmJvdC1hdXRob3JlZCIsImRlcGVuZGVuY3ktdHlwZTo6cGF0Y2giXX0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant