[libgraphql-core-v1] Update plan: operation types use 'schema lifetime (AD17)#100
Merged
Conversation
…tSpread/FragmentRegistry/ExecutableDocument sketches
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the libgraphql-core-v1 implementation plan to reflect the AD17 architectural decision: operation types borrow from &Schema via a 'schema lifetime to enable zero-copy access to schema definitions.
Changes:
- Updated the high-level architecture summary and AD11 to align
FieldSelectionwith schema-borrowing references (vs pre-resolved metadata). - Added AD17 documenting the
'schemalifetime design across operation types and the resulting removal of serde support for operations. - Updated Task 18/19 code sketches and notes to use
'schemaconsistently and reflect the new borrowing model.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ts, FragmentRegistry sharing design
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the implementation plan to reflect the
'schemalifetime design for all operation types, established through discussion before proceeding with Tasks 16+.New Architectural Decision: AD17
All operation types (
Operation,SelectionSet,Selection,FieldSelection,InlineFragment,FragmentSpread,Fragment,FragmentRegistry,ExecutableDocument) carry a'schemalifetime, borrowing from&'schema Schema. This enables zero-copy access to schema definitions instead of pre-resolved metadata copies.Key changes to plan:
FieldSelectionholds&'schema FieldDefinition+&'schema GraphQLTyperefs instead offield_return_type_name/parent_type_name/requires_selection_set'schemalifetime, serde derives removed'sto'schemathroughoutVariableandOperationKindremain owned (schema-independent)No code changes — plan doc only.
🤖 Generated with Claude Code