test(scss-parser): skip flaky build-in-a-test macro-fusion check (#176) - #175
Merged
Conversation
…→ 7s) The SCSS macro-fusion test macro-compiled the (largest) grammar twice — a client `transformRequest` for the no-runtime-import assertion, then `ssrLoadModule` which macro-compiled it again and SSR-loaded its whole dependency graph to run it — pushing the test past the 30s default under CI load. Run the grammar via an ordinary static import instead (the sibling less/jess macro tests already do this; vitest macro-compiles it once), keeping the client transform only for the assertion. Same coverage, ~4.5x faster, no longer flakes the build-free job.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…ransform is ~30s on CI)
The macro-fuses test macro-compiles the largest grammar (~1.5MB fused module) from source via a Vite dev server at test time; under the full build-free suite (isolate:false + HMR-port contention) its cost is unbounded and has exceeded even a 120s timeout, intermittently failing the job for unrelated PRs. Skip it (keeping the fast index.ts CST-exclusion test) until the fusion is verified on a built artifact in a build-gated job. Tracked in #176.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SCSS
ast-macro-compiled"macro-fuses" test macro-compiles the largest grammar (~1.5MB fused module) from source through a Vite dev server at test time — a build masquerading as a unit test. Under the full build-free suite (isolate: false, macro tests colliding on Vite's HMR port 24678) its cost is unbounded; it has exceeded even a 120s timeout and intermittently fails theSource tests (build-free)job for unrelated PRs (it is pre-existing infra debt, not a grammar regression).This temporarily skips just that test (the fast
index.tsCST-exclusion test in the same file still runs), so the build-free job is reliable again. The proper fix — verify the fusion on a built artifact in a build-gated job instead of recompiling through Vite — is tracked in #176.