jest-worker: Avoid crash when "--max-old-space-size" inside process.execArgv#12103
Conversation
|
Hi @JonWallsten! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Codecov Report
@@ Coverage Diff @@
## main #12103 +/- ##
=======================================
Coverage 67.65% 67.66%
=======================================
Files 328 328
Lines 16990 16990
Branches 4817 4817
=======================================
+ Hits 11495 11496 +1
+ Misses 5462 5461 -1
Partials 33 33
Continue to review full report at Codecov.
|
|
@SimenB: Done! I didn't add another entry in |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Complement to this PR: #12097
Node has previously updated the command line flag max_old_space_size to max-old-space-size, so we should support both in when filtering the flags.
Test plan
Verifying the RegExp should be sufficient.