Fix autolink rendering in djot-reader.lua - #22
Merged
Conversation
The pandoc reader had no handlers for `url` and `email` AST nodes emitted by the parser for autolinks (`<https://example.com>` / `<foo@example.com>`), so any document containing one aborted with "attempt to call a nil value". Both nodes carry `.destination` and string-content children — the exact shape `Renderer:link` already consumes — so aliasing is sufficient. Closes jgm#21.
Contributor
Author
|
The CI failures seem to be unrelated to this PR. I pushed #23 to fix the CI. That's LLM generated, but looks fine to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pandoc reader had no handlers for
urlandemailAST nodes emitted by the parser for autolinks (<https://example.com>/<foo@example.com>), so any document containing one aborted with "attempt to call a nil value".Both nodes carry
.destinationand string-content children — the exact shapeRenderer:linkalready consumes — so aliasing is sufficient. Closes #21.I didn't see a natural place to fit a test for this. The following would work, but feels a bit weird: