Skip to content

Add index pages - #18

Closed
parkr wants to merge 2 commits into
jlord:masterfrom
parkr:index-file
Closed

parkr wants to merge 2 commits into
jlord:masterfrom
parkr:index-file

Conversation

@parkr

@parkr parkr commented Apr 23, 2015

Copy link
Copy Markdown

Both for HTML & Markdown.

Coming from Liquid, handlebars is a bit weird. Had to run but wanted to share what I have so far. Pretty simple.

Ref: #16.

@parkr

parkr commented Apr 23, 2015

Copy link
Copy Markdown
Author

Hey! ✨

I think I have come to a solution I'm OK with. It's by no means perfect and the design for the HTML page just steals the comments paradigm, but hey, it's something. Makes browsing the issues a little easier. Just needs a little design love. 💄

HTML

screen shot 2015-04-23 at 10 58 46 am

MD

screen shot 2015-04-23 at 10 58 35 am

Let me know what you think!

/cc @jlord @muan

@jlord

jlord commented Apr 23, 2015

Copy link
Copy Markdown
Owner

@parkr I am so excited about this! I'll pull it down and try it out a little later today ✨

@parkr

parkr commented Apr 23, 2015

Copy link
Copy Markdown
Author

@parkr I am so excited about this! I'll pull it down and try it out a little later today

Yay! 🎉 Can't wait to hear your thoughts. Definitely opportunity to clean up writemarkdown/writehtml in terms of the input data / template / output file pipeline but it might also confuse more than it helps. :)

@jlord

jlord commented Apr 27, 2015

Copy link
Copy Markdown
Owner

Kewl, it looks good to me! @muan thoughts?

@krlmlr

krlmlr commented Apr 30, 2015

Copy link
Copy Markdown
Contributor

This doesn't work well when more than one repository is queried for. Might get auto-fixed if each repo is put into a single subdirectory (#4).

@jlord jlord mentioned this pull request May 1, 2015
@parkr

parkr commented May 11, 2015

Copy link
Copy Markdown
Author

@krlmlr What fails?

@krlmlr

krlmlr commented May 11, 2015

Copy link
Copy Markdown
Contributor

I tried only once and found that links on the index page sometimes refer to wrong repositories/issues.

@parkr

parkr commented Jun 15, 2015

Copy link
Copy Markdown
Author

@krlmlr For which repos did you run this? I'd be interested in fixing that bug.

@krlmlr

krlmlr commented Jun 15, 2015

Copy link
Copy Markdown
Contributor

I don't remember. Does it work for you when you try downloading for two (random, unrelated) repos at once? Or for five repos?

@parkr parkr closed this Aug 20, 2015
@parkr
parkr deleted the index-file branch August 20, 2015 01:29
@Muriuki-njeri

Copy link
Copy Markdown

qul staff for sure.

@ntdb ntdb mentioned this pull request Oct 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants