feat: add a desc. for RoPE - #12
Open
mehrdad3301 wants to merge 3 commits into
Open
mehrdad3301 wants to merge 3 commits into
mehrdad3301 wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a short desc for RoPE
Let me know what you think !
I wanted to add an incremental description for the implementation, much like RMSNorm, but skipped as it is straight forward I guess if you strictly follow the formulas. I was also thinking of reusing the same kernel for RoPE prefill in decode, since it has cos/sin tables precomputed. The description can also be incremental. First the implementation without the precomputed values, and then the precomputation and full implementation. Let me know what you think !
Thanks !