Add experimental support for 1.8's new Context based database/sql functions - #270
Merged
Merged
Conversation
Collaborator
|
@jmoiron what do you think it's needed to get this merged? I'd be happy to help testing out if needed. Thank you! |
|
@jmoiron can you take a look at this? |
Contributor
|
nice! I created #278 before finding this PR. I would leave it open anyways. |
Contributor
|
Is there a reason why transaction does not support |
vbehar
added a commit
to vbehar/dat
that referenced
this pull request
Jun 23, 2017
allow to pass context.Context to the sql package, using the *Context funcs on sqlx needs a more recent version of sqlx - see jmoiron/sqlx#270
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds experimental support for Go 1.8's new
context.Contextbased functions. Tests have been duplicated for the Context based functions to bring them up to parity.