🔒 fix: prevent application crash on Symbol property access in proxy#19
Conversation
The `useSquawk` and `usePending` proxy traps were adding properties to their context tracking unconditionally. When internal operations (like React DevTools or frameworks) check for Symbols (e.g., `Symbol.iterator`, `Symbol.toStringTag`), this resulted in adding a Symbol to a context tracking Set, which would later cause a type error and application crash when attempting to retrieve subscribers for that Symbol. This change safely ignores property accesses that are not strings. Co-authored-by: johnstrand <11484777+johnstrand@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🎯 What: This PR fixes a vulnerability where accessing a Symbol on the
⚠️ Risk: If any code (React internals, external dev tools, or third-party packages) accesses a Symbol on the proxy, the application would crash due to improperly tracking the Symbol in the proxy
useSquawkorusePendingproxies would lead to an application crash.gettrap and then failing to process it during context subscriber lookups.🛡️ Solution: Added a
typeof prop === "string"check in the Proxygethandlers for bothuseSquawkandusePendingto ensure only intended string properties are tracked as contexts. Also added tests to ensure regressions don't occur.PR created automatically by Jules for task 17171355926253609186 started by @johnstrand