Skip to content

🔒 Fix unhandled exception in Redux DevTools JSON parsing#20

Merged
johnstrand merged 1 commit into
masterfrom
fix/redux-devtools-json-parse-crash-12901159229705250362
Jul 8, 2026
Merged

🔒 Fix unhandled exception in Redux DevTools JSON parsing#20
johnstrand merged 1 commit into
masterfrom
fix/redux-devtools-json-parse-crash-12901159229705250362

Conversation

@johnstrand

Copy link
Copy Markdown
Owner

🎯 What: The application could crash due to an unhandled exception if JSON.parse encounters invalid JSON from a Redux DevTools message.
⚠️ Risk: If the Redux dev tools extension or an attacker manipulated the messages, it could crash the application for developers relying on dev tools for debugging.
🛡️ Solution: Added a try...catch block around the JSON parsing logic inside the Redux dev tools message subscriber. If the message payload is invalid, the error is caught and gracefully ignored, leaving the state untouched. This prevents an uncaught exception from propagating.

New tests were also added in src/__tests__/Squawk.reduxDevTools.test.ts to assert that valid JSON correctly updates the store state, and that invalid JSON is safely ignored without throwing.


PR created automatically by Jules for task 12901159229705250362 started by @johnstrand

Adds a try/catch block around `JSON.parse(message.state)` in the Redux dev tools subscriber to prevent the application from crashing when dev tools send invalid JSON data. Tests were also added to verify the happy and error paths.

Co-authored-by: johnstrand <11484777+johnstrand@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@johnstrand johnstrand merged commit b8f40f1 into master Jul 8, 2026
@johnstrand johnstrand deleted the fix/redux-devtools-json-parse-crash-12901159229705250362 branch July 8, 2026 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant