🔒 Fix unhandled exception in Redux DevTools JSON parsing#20
Conversation
Adds a try/catch block around `JSON.parse(message.state)` in the Redux dev tools subscriber to prevent the application from crashing when dev tools send invalid JSON data. Tests were also added to verify the happy and error paths. Co-authored-by: johnstrand <11484777+johnstrand@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🎯 What: The application could crash due to an unhandled exception if
⚠️ Risk: If the Redux dev tools extension or an attacker manipulated the messages, it could crash the application for developers relying on dev tools for debugging.
JSON.parseencounters invalid JSON from a Redux DevTools message.🛡️ Solution: Added a
try...catchblock around the JSON parsing logic inside the Redux dev tools message subscriber. If the message payload is invalid, the error is caught and gracefully ignored, leaving the state untouched. This prevents an uncaught exception from propagating.New tests were also added in
src/__tests__/Squawk.reduxDevTools.test.tsto assert that valid JSON correctly updates the store state, and that invalid JSON is safely ignored without throwing.PR created automatically by Jules for task 12901159229705250362 started by @johnstrand