Skip to content

🔒 Fix application crash on unhandled Symbol properties in proxies#21

Merged
johnstrand merged 2 commits into
masterfrom
fix-proxy-symbol-crash-14356909526467052655
Jul 8, 2026
Merged

🔒 Fix application crash on unhandled Symbol properties in proxies#21
johnstrand merged 2 commits into
masterfrom
fix-proxy-symbol-crash-14356909526467052655

Conversation

@johnstrand

Copy link
Copy Markdown
Owner

🎯 What: Fixed a vulnerability in createStore proxies (usePending and useSquawk) where arbitrary symbol properties were being mistakenly added to internal state trackers, causing potential application crashes.

⚠️ Risk: If a system accessing these proxies (like a debugging tool, a React internal mechanism, or malicious code) attempts to read a Symbol off of them, the symbol was improperly tracked as a string context. This would cause downstream string manipulations on the context tracker to fail catastographically, taking down the frontend application.

🛡️ Solution: Modified the get trap in both usePending and useSquawk proxies to only register the property in the context tracker if (typeof prop === "string"). Non-string property accesses (like Symbols) simply return the value normally without attempting to track them. Includes accompanying unit tests for safety.


PR created automatically by Jules for task 14356909526467052655 started by @johnstrand

Co-authored-by: johnstrand <11484777+johnstrand@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@johnstrand johnstrand merged commit dfaa6d7 into master Jul 8, 2026
1 check passed
@johnstrand johnstrand deleted the fix-proxy-symbol-crash-14356909526467052655 branch July 8, 2026 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant