Skip to content

🧪 Add tests for subscribe method#24

Merged
johnstrand merged 1 commit into
masterfrom
tests/add-subscribe-test-18154154866919942425
Jul 8, 2026
Merged

🧪 Add tests for subscribe method#24
johnstrand merged 1 commit into
masterfrom
tests/add-subscribe-test-18154154866919942425

Conversation

@johnstrand

Copy link
Copy Markdown
Owner

🎯 What: Added tests for the untested subscribe() method in the createdStore function.

📊 Coverage:

  • Notifying a subscriber when its specific context updates.
  • Not notifying when unrelated contexts update.
  • Unsubscribe functionality (notifying a subscriber after calling the returned unsubscribe function).

Result: Improved test coverage and reliability of the subscribe functionality.


PR created automatically by Jules for task 18154154866919942425 started by @johnstrand

Added tests for the untested `subscribe()` method in the `createdStore` function.
The new test file `Squawk.subscribe.test.ts` thoroughly tests the `subscribe` method.
It covers the happy path (notifying a subscriber when its specific context updates),
negative cases (not notifying when unrelated contexts update), and the unsubscribe functionality.

Co-authored-by: johnstrand <11484777+johnstrand@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@johnstrand johnstrand merged commit b0235f2 into master Jul 8, 2026
1 check passed
@johnstrand johnstrand deleted the tests/add-subscribe-test-18154154866919942425 branch July 8, 2026 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant