fix: place Cascadia Technology node at root of Management Client tree - #20
Merged
Merged
Conversation
Fix the Management Client site navigation hierarchy so the plugin's
shared node ("Cascadia Technology") sits directly under the tree root
and the "Web Content Workspaces" item node nests under it, instead of
the item node appearing at the root with an empty shared node under
"MIP Plug-ins".
Set AdminPlacementHint.Root for the plugin-level shared node placement
and fall back to PlacementHint.Default for the workspace ItemNode so it
belongs under the shared node. Closes #19.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #19 — the Management Client site navigation tree hierarchy regression.
The plugin's admin content appeared in the wrong places: "Web Content Workspaces" was a root-level parent node (sibling of Site/Cameras/MIP Plug-ins), and "Cascadia Technology" was an empty node under the generic "MIP Plug-ins" root.
Changes
src/WebContent/WebContentPluginDefinition.cs(2 lines):AdminPlacementHintDefault->Root— the "Cascadia Technology" shared node now sits directly under the tree root instead of under "MIP Plug-ins".ItemNodetrailingPlacementHint.Root->PlacementHint.Default— "Web Content Workspaces" now nests under the shared node instead of appearing as a root sibling.Verification
MilestoneSystems.VideoOS.Platform26.1.2 assembly (AdminPlacementHint.Rootplaces the shared node under the tree root;PlacementHint.Defaultnests the item node under the plugin's shared node) and the officialAdminMultiTab/ConfigDumpsamples.WebContent.dllproduced).WebContent.Tests14/14 pass (no SDK-bound seam was testable in the net8 test project).Out of scope (per ticket)
Renaming nodes/icons, Smart Client behavior, wiring up the root-node user control, license/security actions.