Skip to content

Add Object Tagging - #12

Merged
JohnDoneth merged 8 commits into
masterfrom
jd-object-tagging
Aug 21, 2025
Merged

Add Object Tagging #12
JohnDoneth merged 8 commits into
masterfrom
jd-object-tagging

Conversation

@JohnDoneth

@JohnDoneth JohnDoneth commented Aug 13, 2025

Copy link
Copy Markdown

Summary

  • This PR adds optional tagging for S3 objects using the work in Add Object Tagging file_store#3. This will be used for tagging objects as public/private for visibility using S3 policies.
  • Optimizes deleting blobs with many variants by batching the delete operations for the file store backend as well as in the database.
  • Moves telemetry wrappers for storage operations to a FileStore middleware.
  • Adds the operation.name attribute to OpenTelemetry spans for DataDog.
  • Adds optional JSON logging for the telemetry based logger with additional metadata if enabled.
  • Removes support for setting the ACL of file_store entities.

@JohnDoneth JohnDoneth self-assigned this Aug 13, 2025
@JohnDoneth
JohnDoneth marked this pull request as ready for review August 20, 2025 18:14
@JohnDoneth
JohnDoneth requested a review from jdkebling August 20, 2025 18:16

@jdkebling jdkebling left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Great work!

@JohnDoneth
JohnDoneth added this pull request to the merge queue Aug 21, 2025
Merged via the queue into master with commit b647758 Aug 21, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants