Skip to content

[Bridges] Add MOI.Bridge.FirstBridge attribute - #2211

Merged
blegat merged 6 commits into
masterfrom
bl/first_bridge
Nov 14, 2023
Merged

[Bridges] Add MOI.Bridge.FirstBridge attribute#2211
blegat merged 6 commits into
masterfrom
bl/first_bridge

Conversation

@blegat

@blegat blegat commented Jun 20, 2023

Copy link
Copy Markdown
Member

I find this useful when debugging. Getting the second bridge doesn't make much sense since the first bridge might create several constraints.

@odow

odow commented Sep 6, 2023

Copy link
Copy Markdown
Member

What's the status of this? I don't know if we need this in MOI

@blegat

blegat commented Sep 13, 2023

Copy link
Copy Markdown
Member Author

This is often useful for debugging but I was waiting for feedback before continuing

@odow

odow commented Sep 13, 2023

Copy link
Copy Markdown
Member

Is it useful though? For debugging it seems like you could just use the various .model etc.

@blegat

blegat commented Sep 14, 2023

Copy link
Copy Markdown
Member Author

Is it useful though? For debugging it seems like you could just use the various .model etc.

Yes, but it's always a bit hacky, takes time and depends on how many layers and so on. So you can't use in a tutorial for instance.

@odow

odow commented Sep 14, 2023

Copy link
Copy Markdown
Member

Why would we want to use this in a tutorial? How exactly does it help debugging?

@odow

odow commented Nov 3, 2023

Copy link
Copy Markdown
Member

What do you want to do with this? Shall I fix the test and add? Or shall we close?

@odow
odow marked this pull request as ready for review November 6, 2023 01:30
@odow odow changed the title Add FirstBridge [Bridges] Add MOI.Bridge.FirstBridge attribute Nov 6, 2023
Comment thread src/Utilities/functions.jl Outdated
@odow

odow commented Nov 12, 2023

Copy link
Copy Markdown
Member

@blegat merge or close?

Comment thread src/Bridges/Constraint/bridges/functionize.jl
Comment thread src/Bridges/Constraint/bridges/functionize.jl
@blegat
blegat merged commit 460cad7 into master Nov 14, 2023
@blegat
blegat deleted the bl/first_bridge branch November 14, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants