release: CodeDB 0.2.5849 - #732
Conversation
semantic: use negotiated float16 transport
release: CodeDB 0.2.5849
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2f63d18bb1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| .string => |encoded| { | ||
| if (declared_encoding == .float) return error.InvalidEmbeddingResponse; |
There was a problem hiding this comment.
When a response omits encoding_format but supplies a string-valued embedding, declared_encoding is null and this check allows the payload to be decoded as little-endian float16. A malformed or mismatched provider response can therefore silently produce incorrect vectors instead of failing validation; preserve legacy compatibility for unmarked JSON arrays, but accept strings only when the response explicitly declares base64-f16.
Useful? React with 👍 / 👎.
Ships the already production-deployed compact embedding transport from #730 and the 0.2.5849 version/changelog update from #731.
Validation: