Improve hybrid ranking with production-source intent - #736
Conversation
|
👋 Thanks for the contribution! Quick heads-up: this repo lands changes on the current Please retarget this PR via Edit → base branch to the active (Automated hint — reply here if you need a hand.) |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 845cc68eb1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| .exclude_debug = (exclusion_clause and mentions_debug) or | ||
| (production_source and !mentions_debug), | ||
| .exclude_server = (exclusion_clause and mentions_server) or | ||
| (production_source and containsAsciiIgnoreCase(task, "client") and !mentions_server), |
There was a problem hiding this comment.
Scope exclusions to the referenced path class
When a task requests server code but separately excludes another class—such as the added fizz-streaming query, which asks about “server rendering” and then says “Exclude tests and fixtures”—the global exclusion_clause and mentions_server flags incorrectly set exclude_server. The desired server files are consequently multiplied by 0.05 in hybrid ranking and omitted entirely from symbol definitions, including every primary gold file for that benchmark query. The replay harness does not reproduce this behavior because it only demotes servers for phrases such as server-only or client implementation, so its reported gains cannot detect the regression; associate each exclusion with its actual object instead.
AGENTS.md reference: AGENTS.md:L19-L19
Useful? React with 👍 / 👎.
Summary:
Measured React retrieval:
Verification: