fix(handle): notable lines on first spill, whole-line query - #578
Merged
Conversation
query=FAILED used an 80-byte pad and cut off request_id, so Grok paid a second pager turn (4 API calls vs 3 on the previous binary). Search now returns the whole matching line, and the first handle payload includes a bounded excerpt of error-shaped lines so a fat log's "what broke?" is already in the spill.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The #574 A/B on Grok 4.6 was worse on the scoreboard: forced
catof the 168 KB log took 4 API calls vs 3 on the previous binary.query=FAILEDused an 80-byte pad and cut offrequest_id, so the model had to page again.What changed
read_tool_resultqueryreturns the whole matching line.fail/error/panic/ …), still under the 16 KiB threshold. The full blob stays on disk.(cached, 0 cache writes).Live A/B (Grok 4.6, n=2)
Before =
832236a(268 without this). After = this branch.catAfter answers from the first spill (
bash+ completion). No pager turn.