fix(#601,#602): row nouns without mode names; trajectory shapes and shows what turns did - #642
Closed
justrach wants to merge 2 commits into
Closed
fix(#601,#602): row nouns without mode names; trajectory shapes and shows what turns did#642justrach wants to merge 2 commits into
justrach wants to merge 2 commits into
Conversation
interpretJson surfaced the mode verbatim, so a codedb read rendered
'lines · 161 lines' — a tautology — and 'full · 72 lines', where the
mode name is not a decision. A read that carried content now says
'{n} lines'; modes that ARE the fact ('outline', 'symbol') stay.
The file is already the row's detail column.
Co-Authored-By: Codegraff <blackfloofie@codegraff.com>
…turns did Two slices of the inspect-path issue; behavior lifecycle (turn_committed/run_finished) already landed separately. - finalResponseShape walked backward and broke on trailing function_call_output, so every tool-using turn whose tail is tool results archived resp_blocks=0 — an empty turn and a cut-after- execution turn were indistinguishable. Skip those bare items; the shape still describes the last model-authored run. - /trajectory printed 'turn N ✓ 95s · prompt <sha> · <task>' while the node already carries model_calls, the tools bag, tool_errors, token counters, and resp_types. The row now appends calls/tools/errors, cache-hit percent, and response shape when present. - commands_session.zig was over the 600-line ceiling after the above; the /trajectory handler moved to commands_trajectory.zig. Co-Authored-By: Codegraff <blackfloofie@codegraff.com>
This was referenced Aug 26, 2026
Owner
Author
|
Closing as landed on tip. Row nouns without mode names ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
interpretJsonno longer surfaces the CodeDB mode name verbatim. A content-bearing read now interprets as161 linesinstead oflines · 161 lines(tautology) orfull · 72 lines; modes that are themselves the fact (outline,symbol) stay.finalResponseShapebroke its backward walk on a trailing barefunction_call_output, so every tool-using turn whose history ends on tool results (turn cut after execution, crash, attempt_completion's final call) archivedresp_blocks=0— indistinguishable from an empty turn. Those items are now skipped; the shape describes the last model-authored run./trajectoryprinted onlyturn N ✓ 95s · prompt <sha> · <task>. The row now appends what the node already carried: model calls, tool count, tool errors, cache-hit percent, and response shape (text+reasoning), when present.commands_session.zigcrossed the 600-line ceiling with the above; the/trajectoryhandler moved verbatim intocommands_trajectory.zig.Why
The recorder bug made the DGM archive lie about tool-using turns: #270 added
resp_*precisely to separate 'text-only refusal' from 'empty turn', but the Responses+tools path defeated it, so a history ending on tool results was never covered by a test. And/trajectoryis the human inspect path — it ignored fields already on the turn node, leaving a run unreadable compared with a grok-build session folder.Out of scope (kept open on #602)
Live turn stubs in the DGM file, periodic session-transcript flush, and
first_token/call_idon operational traces. Behavior lifecycle (turn_committed/run_finished) already landed earlier. Click-to-expand for line-REPL rows (#601's progressive disclosure) stays out per ADR 0019 —/debugremains the raw path.Verification
agent_tool_label.zig; cut-after-execution shaping case inmainloop_trace.zig. Updated the one render test that asserted the oldsection · N linesstring.zig build testgreen;scripts/eval-tier1.shgreen locally (twice) and via the pre-push hook.