Add asset and customer_asset removal to remove_entity - #3
Merged
Conversation
Extend remove_entity to support standalone assets (via AssetService) and customer-level asset links (via CustomerAssetService), bringing the total supported entity types from 6 to 8. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
5 tasks
kLOsk
added a commit
that referenced
this pull request
Mar 23, 2026
…CPC-cap support Rebased on main after merging PRs #2, #3, #6. Removed duplicate draft_ad_group (kept PR #6's version with preflight checks). Adds: - update_ad_group, draft_callouts, draft_structured_snippets, draft_image_assets - Campaign expansion settings (search_partners, display_network, max_cpc) - Structured error handling for developer token and OAuth issues - Shared _apply_campaign_assets helper replacing duplicated sitelink logic All 77 tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
remove_entityto support two new entity types:asset(standalone assets viaAssetService) andcustomer_asset(customer-level asset links viaCustomerAssetService)customer_assetcomposite IDs (assetId~fieldType).claude/rules/and.cursor/rules/Test plan
uv run pytest— all 14 existing tests passremove_entity(entity_type="asset", entity_id="INVALID")→ returns previewremove_entity(entity_type="customer_asset", entity_id="123~SITELINK")→ returns previewremove_entity(entity_type="bogus", ...)→ validation error listing all 8 types🤖 Generated with Claude Code