Fix/eshipper canadapost invalid serviceid - #11
Merged
Conversation
…e carrier context
Jacob Shilitz (jacobshilitz)
added a commit
to jacobshilitz/karrio-community
that referenced
this pull request
Jan 6, 2026
- Add carrier-specific freightcom_doc_files option to avoid conflicts with FedEx - FedEx requires documentId (pre-uploaded) while Freightcom accepts base64 directly - Prevents SHIPMENTS.DOCUMENTID.INVALID errors when rate shopping across carriers - Maintains backward compatibility with doc_files fallback - See GitLab issue karrioapi#11 for migration details
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce Carrier-Aware Service Resolution for eShipper
This PR introduces a carrier-aware service resolution approach in eShipper to prevent service name collisions across multiple carriers and ensure the correct service IDs are always used.
Bug
eShipper exposes services from multiple carriers (e.g. UPS, Canada Post) that share the same service names (such as “Expedited”).
Service metadata was built using the service name as the unique key, which caused collisions when multiple carriers used the same name.
Because of this:
Solution
eshipper_canadapost_expedited) as unique identifiersStatus
Completed