fix(changelog): unbreak main -- 0.84.1's Tests note was shown cut off - #592
Merged
Conversation
#589 and #591 were both green and merged in that order, and main came out red: #591 added the headline-length test, #589's CI predated it, and nothing re-ran #589 against the newer main. Its "Tests:" note opens with a 161-char sentence, one over the cap. Splitting it in two is the whole fix -- same words, a period instead of a dash. The note now summarises as "the mock schema ... was itself the reason this shipped." instead of breaking off at "CI stayed green …". This is the failure mode issue #585 describes, with a consequence this time: a merge-commit check is only as fresh as the last CI run on the branch, and two independently-green PRs can still land broken.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
main is red right now.
test_newest_release_notes_are_not_truncatedfails on275f96d.What happened
#591 added a test asserting the newest version's release notes are not truncated in
kbagent changelog/ the "What's new" banner. #589 was written and CI'd before that test existed, and was never re-run against the newer main, so both PRs were green and merging them in order produced a red main.Its
Tests:note opens with a 161-character sentence — one character overCHANGELOG_HEADLINE_MAX_CHARS— so the summary broke off at "... and CI stayed green …".The fix
One dash becomes a period. Same words, same order, nothing dropped:
... a shape no real component ever returns, so the off-by-one-level validation matched it and CI stayed green …Tests: the mock schema in \tests/test_config_create_service.py` was itself the reason this shipped.`Note
This is exactly the failure mode in #585 — CI checks the merge commit, but only recomputes it when the PR is updated, so a branch that sits while main moves reports a green result for a merge that no longer exists. #560 hit the same thing earlier today (33 commits stale) and was caught only because the merge was simulated by hand first. Here it landed.
Worth deciding on #585's option 1 (require branches up to date) — this is the second occurrence in one day.