feat(ui): redesign the Search page - #674
Merged
Merged
Conversation
Replace the raw form (native multi-select with a scrollbar, bare selects) with a proper search console that stays inside the NERD UI design system: - Prominent search input with inline icon, autofocus and an Enter hint; a names / config-bodies segmented toggle replaces the type select. - Type filters as toggle pills (tables, buckets, configs, flows, transformations, data apps) with per-type icons instead of the native multi-select. - Per-project failures from the search fan-out (expired session, missing global-search feature) were silently dropped; they now render as a compact 'N projects skipped' notice, grouped by message, expandable to the affected project aliases. A zero-project run says so instead of pretending 'no matches'. - Results are clickable: each row deep-links into its home page via the owning page's ?sel= grammar (storage tables/buckets, configs, transformations, flows), same contract the command palette uses. - Result rows show a typed icon pill (data apps recognized via keboola.data-apps), description subline, and matched-columns hint for tables matched via a column name. - Proper empty, loading and no-results states.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replaces the Search page's raw form (native multi-select with a scrollbar, bare
<select>s, no states) with a proper search console that stays inside the NERD UI design system.errors[](expired session, missingglobal-searchfeature) which the old page dropped entirely — a fleet where every project is skipped rendered as a blank "0 hits", looking broken. They now render as a compact "N projects skipped — expand for details" notice, grouped by message, expandable to the affected project aliases. A zero-project run says "No project could be searched" instead of pretending "no matches".?sel=grammar (storage tables/buckets, configs, transformations, flows) — the same contract the command palette uses, including the project switch and the setter ordering rule (selection written last).component_id == keboola.data-apps), description subline, and a matched-columns hint for tables matched via a column name (DMD-1717 data was already in the response, unused).Why
The page looked unprofessional and, worse, hid the reason searches came back empty: on a config with many registered projects, expired sessions / missing feature flags silently reduced the search to nothing.
Testing
tsc -bclean,npm run buildOK,npm run test53/53.kbagent serve --ui --ui-dist web/frontend/dist: light + dark mode, grouped skip notice with real 51-project fan-out errors, result-row deep links write the expected hash (#/p/<alias>/storage?sel=tables/...); a cross-project link into a project whose list cannot load is dropped by the target page (existing intended behavior).No server changes;
configuration-rowresults stay non-navigable (no stable parent-config link in the result shape).