fix(oauth-url): make the authorization link survive terminal wrapping (SUPPORT-17391) - #707
Closed
ZoraJel wants to merge 4 commits into
Closed
fix(oauth-url): make the authorization link survive terminal wrapping (SUPPORT-17391)#707ZoraJel wants to merge 4 commits into
ZoraJel wants to merge 4 commits into
Conversation
Co-Authored-By: Zora Jelínková <zora.jelinkova@keboola.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
…T-17391) Co-Authored-By: Zora Jelínková <zora.jelinkova@keboola.com>
…-17391) Co-Authored-By: Zora Jelínková <zora.jelinkova@keboola.com>
… agents (SUPPORT-17391) Co-Authored-By: Zora Jelínková <zora.jelinkova@keboola.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
config oauth-urlprints a ~200-char URL (token+ encodedsapiUrl+#/<component>/<config>), so it never fits one terminal row. Two layers then truncate it, and both produce the same misleading browser error —Failed to load config data. Please contact us on support@keboola.com— becausetoken/sapiUrlcome first and survive while theconfig_idin the fragment is lost:Fixes:
The click target is now a one-row label carrying the full URL as the OSC-8 target, so no wrapping can truncate it; the URL is still printed verbatim on one unwrapped line for copy/paste. Also adds
--open, which hands the complete URL to the existingauth.environment.open_browser(JSON then reportsopened_in_browser) for terminals without hyperlink support.kai ask/kai chat/kai chat-detailprinted assistant answers throughconsole.print(...)with default layout, so a URL inside an answer got the same destructive Rich newlines — those now passsoft_wrap=True.--json(data.url) was never affected.Docs:
commands-reference.md+ agotchas.mdentry tell agents to use--open(or--json) instead of pasting the link into a chat transcript, since a wrapping renderer is outside kbagent's control.Unchanged on purpose: token TTL (1 h vs the UI's 48 h) and any config preflight before minting the token.
Release Notes
Fixed the
config oauth-urlauthorization link being truncated by terminal wrapping (which surfaced as "Failed to load config data" in the OAuth wizard): the clickable target is now a shortAuthorize in browserlabel carrying the whole URL, the URL is printed unwrapped, and a new--openflag launches it in the default browser. Kai answers are no longer hard-wrapped either.Link to Devin session: https://app.devin.ai/sessions/e0d8eb25504b4b7cb6b1f9c354d448e3
Requested by: @ZoraJel