PRDCT-658: flip dev-domain links whose targets already live on help - #1094
Open
Iamfle4ka wants to merge 2 commits into
Open
PRDCT-658: flip dev-domain links whose targets already live on help#1094Iamfle4ka wants to merge 2 commits into
Iamfle4ka wants to merge 2 commits into
Conversation
25 links across 14 files, found by check-redirects.mjs --flippable (#1091) plus two checker-blind cases (pre-rename /extend/docker/running/ URLs absent from the 175-row map). Anchors preserved where the target heading exists and verified in dist; one dead dev anchor (#technical-differences, now a redirect stub that would drop it) reworded to /extend/component/#component-types. Deliberately NOT flipped, still reported by --flippable: - 3 SSH-tunnel links in database pages — #1019 owns those files - 4 /integrate/storage-family links — their real home is /storage/api/, which lands with #1053; /storage/ today would strand them one level short Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Iamfle4ka
marked this pull request as ready for review
August 26, 2026 17:27
keboola-pr-reviewer-bot
previously approved these changes
Aug 26, 2026
keboola-pr-reviewer-bot
left a comment
There was a problem hiding this comment.
Verdict: auto_approve (risk 2/5) · profile connection-docs
Auto-approve: content-only dev-domain link flips, all targets and anchors verified present at HEAD.
Concerns:
src/content/docs/components/writers/storage/aws-s3/index.md: Whole-file line-ending/whitespace churn with identical prose; will noise up git blame.
keboola-pr-reviewer-bot
dismissed
their stale review
August 26, 2026 17:29
Dismissing prior approval — superseded by a fresh review on this PR.
# Conflicts: # src/content/docs/components/extractors/other/generic/generic.md # src/content/docs/transformations/index.md # src/content/docs/transformations/mappings/index.md
keboola-pr-reviewer-bot
dismissed
their stale review
August 27, 2026 20:09
Dismissing prior approval — a new commit was pushed and this review was for an earlier SHA. Run @keboola-pr-reviewer-bot review to get a fresh verdict.
|
New commit on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linear: PRDCT-658 · mechanical follow-up from the redirect contract in #1091.
What
25
developers.keboola.comlinks flipped to in-repo paths across 14 files — every link whose target already resolves onmain, percheck-redirects.mjs --flippable, plus two the checker is blind to (pre-rename/extend/docker/running/…URLs that predate the 175-row map; flipped to the canonical/extend/component/running/#running-transformations).Anchors are preserved, not dropped — the checker's naive suggestions lose them. All six flipped anchors verified present in the built HTML (
#component,#generic-extractor,#component-types,#running-transformations,#generate-action,#data-type-conversions). One malformed dev anchor (#generic-extractor/) fixed on the way. One judgment rewrite:[technical differences](…/extend/custom-science/#technical-differences)— that path is now a redirect stub, which drops anchors, and the heading no longer exists; reworded to point at/extend/component/#component-types.Deliberately NOT flipped — still reported by
--flippable(7)database/{index,mysql,postgresql}/integrate/storage/+ tokens'[Storage API](…/integrate/)/storage/api/(+clients/), which lands with #1053 — flipping to/storage/today strands them one level short and nothing would ever re-flag themAlso untouched: 12 files linking dev
/overview/api/(UNSURE row, gated on PRDCT-550),/cli/(home lands with #1093), and 3generic-extractorlinks (land with #1054).Verification
npm run buildclean; audit broken-internal-links 40 → 35 (flips fixed five; every remaining one pre-dates this PR)--flippableafter: exactly the 7 skipped links, nothing newdist/; all kept anchors grep-verified🤖 Generated with Claude Code