fix(servicenow): forward sysparm_offset in pagination and fix undefined error in _notify_update - #6725
Merged
Conversation
…ed var in _notify_update
|
|
Contributor
|
🎉 Fantastic work @Veydop! Your very first PR to keep has been merged! 🎉🥳 You've just taken your first step into open-source, and we couldn't be happier to have you onboard. 🙌 For any support, feel free to reach out on the community: https://slack.keephq.dev. Happy coding! 👩💻👨💻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6723
📑 Description
Fixes ServiceNow pagination, which was stuck on page 1 because sysparm_offset was always hardcoded to 0 instead of using the caller's requested offset. Also fixes a NameError in _notify_update's failure path, which referenced an undefined resp instead of response.syntax
✅ Checks
ℹ Additional Information
No breaking changes, no new dependencies.