fix(topologies): skip deleted incidents when looking up application incidents - #6733
Merged
shahargl merged 1 commit intoAug 23, 2026
Merged
Conversation
…ncidents Deleting an incident only marks it deleted; the row keeps its incident_application link. The lookup query did not filter on status, so a new alert for the same application reused the deleted incident instead of creating a new one. Exclude deleted incidents from the lookup and add a regression test (RED on the old query, green with the filter). Fixes keephq#6732
|
|
Contributor
|
🌟 Fantastic work @Georgefifth! Your very first PR to keep has been merged! 🎉🥳 You've just taken your first step into open-source, and we couldn't be happier to have you onboard. 🙌 For any support, feel free to reach out on the community: https://slack.keephq.dev. Happy coding! 👩💻👨💻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6732
Problem
Deleting a topology incident only marks it
deleted— the row keeps itsincident_applicationlink._get_application_based_incidentdid not filter on status, so the next alert for that application reused the deleted incident instead of creating a new one.Solution
Exclude deleted incidents from the lookup:
Incident.status != IncidentStatus.DELETED.value(same pattern already used inkeep/api/core/db.py). One-line change, no behavior change for firing/resolved/acknowledged incidents.Result
test_get_application_based_incident_skips_deleted_incident: fails on the old query (RED), passes with the filter (GREEN)tests/test_topology.py: 13/13 passedtests/test_incidents.py: 25/25 passed (no regressions)ruff checkclean on both touched files