fix(iohandler): don't drop empty list/dict/tuple and literal False args to keep.* functions - #6738
Open
mmustafasenoglu wants to merge 1 commit into
Open
Conversation
…gs to keep.* functions Fixes keephq#6728 The argument-filtering guard in _parse_token was too complex and incorrectly dropped: - Empty containers: [], {}, () (falsy but not caught by special cases) - Literal False (equals 0 in Python, so _arg == 0 matched but then _arg is not False excluded it) Changed the guard to simply if _arg is not None: since _arg is initialized to None and only stays None when parsing produces no value (e.g., a nested keep.* call that returns nothing). This correctly preserves all legitimate argument values including empty strings, zero, false, and empty collections.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6728
Problem
The argument-filtering guard in
_parse_tokenwas too complex and incorrectly dropped:[],{},()(falsy but not caught by special cases)False(equals0in Python, so_arg == 0matched but then_arg is not Falseexcluded it)Solution
Changed the guard to simply
if _arg is not None:since_argis initialized toNoneand only staysNonewhen parsing produces no value (e.g., a nestedkeep.*call that returns nothing). This correctly preserves all legitimate argument values including empty strings, zero, false, and empty collections.