fix(topology): preserve incident continuity and application identity across topology re-imports - #6740
Open
Prabal864 wants to merge 1 commit into
Open
Conversation
…across topology re-imports Closes keephq#6731
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes #6731.
When importing or re-importing topology YAML, TopologiesService.clean_before_import deletes all existing TopologyApplication records for the tenant. On recreation, create_applications_by_tenant_id assigns brand new internal UUIDs to applications that do not specify explicit IDs in YAML.
Because topology incidents link to applications via Incident.incident_application == application.id, TopologyProcessor._get_application_based_incident fails to locate the active incident for the recreated application and creates a duplicate incident when subsequent alerts fire.
Fix
Testing
Checklist