Clarify press key input format - #243
Open
masnwilliams wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--keyvalue accepts one X11 keysym or chordCtrl+minusand repeated-key examplescomputer type --textfor text inputRollout
Merge after kernel/kernel-images#364 is deployed so the documented punctuation form is supported by the runtime.
Testing
make testmake build./bin/kernel browsers computer press-key --helpNote
Low Risk
Help text and README only; no runtime or parsing logic changes.
Overview
Documentation-only update for
kernel browsers computer press-key: it clarifies how to pass--keyvalues and when to usecomputer typeinstead.The
--keyflag is described as one X11 keysym or chord per value (examples:Return,Ctrl+t,Ctrl+minus) in both README andpress-key --help. A short note explains using multiple--keyflags for sequential or repeated presses (e.g.--key BackSpace --key BackSpace) and points users tocomputer type --textfor entering text rather than misusingpress-key.No changes to command behavior or API calls; rollout note in the PR ties the
Ctrl+minusexample to a separate kernel-images deployment.Reviewed by Cursor Bugbot for commit 8065c72. Bugbot is set up for automated code reviews on this repo. Configure here.